Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ensure disk has enough space to download file into #268

Merged
merged 14 commits into from
Sep 7, 2023
Merged

feat: ensure disk has enough space to download file into #268

merged 14 commits into from
Sep 7, 2023

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Aug 14, 2023 •
edited
Loading

Closes #

Changes

Why?

To solve the problem of downloads failing because there isn't enough space once download has been partially completed.

Trials Performed

  1. Set download path to disk partition with space
2023-08-15T07:28:47.450130Z DEBUG uplink::collector::downloader: Download requires 222.5 KiB; Disk free space is 233.6 GiB
  1. Set path to a disk partition that doesn't have enough space
  2023-08-15T07:42:36.714623Z DEBUG uplink::collector::downloader: Download requires 986 KiB; Disk free space is 400 KiB

  2023-08-15T07:42:36.714652Z ERROR uplink::collector::downloader: Download failed: Disk space is insufficient: 400 KiB

@de-sh de-sh marked this pull request as ready for review August 15, 2023 07:44
@de-sh de-sh requested a review from tekjar August 16, 2023 16:08
@de-sh de-sh merged commit dfc073d into main Sep 7, 2023
2 checks passed
@de-sh de-sh deleted the check-size branch September 7, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekjar tekjar Awaiting requested review from tekjar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@de-sh